Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable MTP #37001

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Enable MTP #37001

wants to merge 3 commits into from
+5 −30

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 22, 2025 •
edited
Loading

Summary of the Pull Request

Update MSTest to latest and switch to Microsoft.Testing.Platform instead of VSTest.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@Youssef1313 Youssef1313 marked this pull request as draft January 22, 2025 05:13
@Youssef1313
Copy link
Member Author

I'm not seeing a build triggered on this PR. Is CI for this repo manually triggered?

@Youssef1313 Youssef1313 marked this pull request as ready for review January 22, 2025 05:21
@Youssef1313 Youssef1313 requested a review from a team as a code owner January 22, 2025 05:48
@crutkas
Copy link
Member

crutkas commented Jan 22, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@crutkas
Copy link
Member

crutkas commented Jan 22, 2025

@Youssef1313 can you ping me internally? I would love to ask a few questions on this.

@DHowett as FYI

@jaimecbernardo
Copy link
Collaborator

Thanks for opening this PR. CI is failing because of some XAML style errors that got into main. Please merge latest main in to fix that. Thank you

@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 37001 in repo microsoft/PowerToys

@crutkas
Copy link
Member

crutkas commented Jan 22, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313 Youssef1313 marked this pull request as draft January 22, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @crutkas @jaimecbernardo